fix(scores): skip sampling if OTEL sampler not available#1241
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
In
resource_manager.py,add_score_tasknow defaults to in-sample if OpenTelemetry sampler is unavailable, ensuring scores are processed correctly.add_score_taskinresource_manager.py, skip sampling if OpenTelemetry sampler is not available by defaulting to in-sample.event['body'].trace_idisNoneby ensuring scores are not sampled out.add_score_taskto improve readability and logic flow.This description was created by
for d77d697. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixes scoring sampling behavior in the Python SDK to ensure scores are not unintentionally dropped when OpenTelemetry sampling is not configured.
langfuse/_client/resource_manager.pyto treat scores as 'in-sample' by default when using ProxyTracerProvider